alamb commented on code in PR #20627:
URL: https://github.com/apache/datafusion/pull/20627#discussion_r2913584803
##########
datafusion/datasource/src/file_stream.rs:
##########
@@ -126,7 +126,15 @@ impl FileStream {
Ok(reader) => {
// include time needed to start opening in
`start_next_file`
self.file_stream_metrics.time_opening.stop();
- let next = self.start_next_file().transpose();
+ let next = {
Review Comment:
I wonder if there is any way to make this more concise (to avoid
complicating the FileStream more).
Perhaps a method on `file_stream_metrics so this could look like
```rust
let scanning_total_metric =
self.file_stream_metrics.time_scanning_total.timer()` 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
