findepi commented on PR #11508: URL: https://github.com/apache/datafusion/pull/11508#issuecomment-2232945620
the 1 MB file size limit is arbitrary, but in line with gihub's suggestions There already is one file bigger in the repo (`./docs/logos/Datafusion_Branding_Guideline.pdf`). This is a kind of file for which git-lfs could be used. i experimented with this check in the following test PRs - new big file https://github.com/findepi/datafusion/pull/1 - existing big file, copied https://github.com/findepi/datafusion/pull/2 - new small files https://github.com/findepi/datafusion/pull/3 The error reporting isn't ideal. the offending file name is NOT printed out to console. It's only visible on the Summary page of the workflow. Hopefully this can be improved in the check itself, or the code inlined. I did that, but then using existing action looks so more aesthetically... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
