sdf-jkl commented on PR #20497: URL: https://github.com/apache/datafusion/pull/20497#issuecomment-4061492128
They are unlikely to be highly selective for row pruning, but we can't reliably assume they are always less selective than other predicates. My implementation here did the opposite and prioritized them in the evaluation order, which is a mistake. At this point, I think the rule itself might be unnecessary, and we could consider closing the issue. I can clean up the docs and the function placeholder in `row_filter.rs` in this PR. Current doc saying we should prioritized sorted columns: https://github.com/apache/datafusion/blob/9b7d0924bcd3fd92824704903937a5945bf0d62f/datafusion/datasource-parquet/src/row_filter.rs#L45-L60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
