martin-g commented on code in PR #3699:
URL: https://github.com/apache/datafusion-comet/pull/3699#discussion_r2936763497
##########
spark/src/main/spark-3.4/org/apache/spark/sql/comet/shims/ShimSparkErrorConverter.scala:
##########
@@ -243,6 +245,18 @@ trait ShimSparkErrorConverter {
QueryExecutionErrors
.intervalArithmeticOverflowError("Interval arithmetic overflow",
"", sqlCtx(context)))
+ case "FileNotFound" =>
+ val msg = params("message").toString
+ // Extract file path from native error message and format like Hadoop's
+ // FileNotFoundException: "File <path> does not exist"
+ val path = "Object at location (.+?) not found".r
Review Comment:
Maybe extract this Regex to a constant, so it is not recompiled on every
usage.
Same for the other shims
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
