wForget commented on code in PR #3708:
URL: https://github.com/apache/datafusion-comet/pull/3708#discussion_r2937877711
##########
spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala:
##########
@@ -389,6 +390,10 @@ case class CometExecRule(session: SparkSession) extends
Rule[SparkPlan] {
var newPlan = transform(planWithJoinRewritten)
+ // Record coverage stats for metrics
+ val stats = CometCoverageStats.forPlan(newPlan)
Review Comment:
CometExecRule may be applied multiple times. Could this lead to
double-counting of metrics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
