kazuyukitanimura commented on code in PR #604:
URL: https://github.com/apache/datafusion-comet/pull/604#discussion_r1681779734
##########
native/core/src/parquet/read/levels.rs:
##########
@@ -121,8 +121,8 @@ impl LevelDecoder {
match self.mode {
Mode::RLE => {
if self.current_value as i16 == max_def_level {
- value_decoder.read_batch(vector, n);
bit::set_bits(vector.validity_buffer.as_slice_mut(),
vector.num_values, n);
+ value_decoder.read_batch(vector, n);
Review Comment:
`value_decoder.read_batch` may unset `validity_buffer` for decimal values if
the value is larger than precision limit, so that those values be understood as
null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
