timsaucer commented on code in PR #20449: URL: https://github.com/apache/datafusion/pull/20449#discussion_r2956020994
########## datafusion/expr-common/src/accumulator.rs: ########## @@ -48,7 +48,7 @@ use std::fmt::Debug; /// [`evaluate`]: Self::evaluate /// [`merge_batch`]: Self::merge_batch /// [window function]: https://en.wikipedia.org/wiki/Window_function_(SQL) -pub trait Accumulator: Send + Sync + Debug { +pub trait Accumulator: Send + Sync + Debug + std::any::Any { Review Comment: I left a comment on the other thread but basically I want to remove these as we go: https://github.com/apache/datafusion/pull/20812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
