timsaucer commented on code in PR #20451: URL: https://github.com/apache/datafusion/pull/20451#discussion_r2977109343
########## datafusion/physical-optimizer/src/optimizer.rs: ########## @@ -50,7 +50,7 @@ use datafusion_physical_plan::ExecutionPlan; /// `PhysicalOptimizerRule`s. /// /// [`SessionState::add_physical_optimizer_rule`]: https://docs.rs/datafusion/latest/datafusion/execution/session_state/struct.SessionState.html#method.add_physical_optimizer_rule -pub trait PhysicalOptimizerRule: Debug { +pub trait PhysicalOptimizerRule: Debug + std::any::Any { Review Comment: With regard to that, may I interest you in this PR which removes almost 1200 lines? https://github.com/apache/datafusion/pull/20812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
