AdamGS commented on code in PR #21128:
URL: https://github.com/apache/datafusion/pull/21128#discussion_r2977124844


##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -421,6 +419,10 @@ fn push_down_all_join(
     // 3) should be kept as filter conditions
     let left_schema = join.left.schema();
     let right_schema = join.right.schema();
+
+    let left_schema_columns = schema_columns(left_schema.as_ref());

Review Comment:
   I think there might be an even better thing here, but I need to do another 
pass



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to