2010YOUY01 commented on issue #3771: URL: https://github.com/apache/datafusion-comet/issues/3771#issuecomment-4149666359
Sharing a perspective from a DataFusion contributor: Forking SMJ, iterating on it within Comet for your specific use cases, and periodically syncing the accumulated improvements back upstream could be a good idea. This can reduce review pressure on DataFusion. Small incremental PRs often lack sufficient context about future directions, and may end up being revised multiple times. In contrast, accumulating changes downstream allows them to be validated in real workloads first, so when proposing them upstream, we could have stronger confidence. It also makes reviews easier. Instead of sporadic changes that reviewers may lose context on, related improvements can be grouped and reviewed together. Even if the total diff is large, it can still be upstreamed as a series of smaller PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
