andygrove opened a new pull request, #3861:
URL: https://github.com/apache/datafusion-comet/pull/3861

   ## Which issue does this PR close?
   
   Closes #3834.
   
   ## Rationale for this change
   
   In `MultiPartitionShuffleRepartitioner::shuffle_write()`, spill files are 
copied to the final shuffle output wrapped in `BufReader`. This is 
counterproductive because `std::io::copy` already uses an internal buffer, and 
wrapping in `BufReader` defeats the `copy_file_range`/`sendfile` zero-copy 
specialization on Linux since the source is no longer a raw `File`.
   
   ## What changes are included in this PR?
   
   Remove the `BufReader` wrapper and pass the raw `File` handle directly to 
`std::io::copy`. Also removes the now-unused `BufReader` import.
   
   ## How are these changes tested?
   
   Covered by existing shuffle tests. This is a minimal change that only 
affects the I/O path used for copying spill files.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to