0lai0 commented on PR #3798: URL: https://github.com/apache/datafusion-comet/pull/3798#issuecomment-4175791208
Thank you all for the review. I've updated the test to strictly use `spark.comet.scan.impl=native_datafusion` as requested. After checking further, I've simplified the fix by changing `metrics.add` to `metrics.set`. This ensures idempotency: if Catalyst evaluates the metric multiple times, it updates to the same fixed value rather than accumulating (which would cause double-counting) or resetting to zero. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
