wjones127 commented on issue #11513: URL: https://github.com/apache/datafusion/issues/11513#issuecomment-2240443324
This generally looks good. I agree that starting with making `ScalarValue` to represent a logical type would be a good starting point. One small nit: I don't think I would lump together `FixedSizeBinary` with `Binary` and `FixedSizeList` with `List`. The fixed lengths often have semantics that should be considered. For example, we use `FixedSizeList<f32>` as a vector, where the length list is the vector dimension. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
