andygrove commented on code in PR #3611:
URL: https://github.com/apache/datafusion-comet/pull/3611#discussion_r3057904389
##########
spark/src/main/scala/org/apache/comet/serde/arrays.scala:
##########
@@ -622,6 +622,80 @@ object CometArrayFilter extends
CometExpressionSerde[ArrayFilter] {
}
}
+object CometArrayExists extends CometExpressionSerde[ArrayExists] {
+
+ override def getSupportLevel(expr: ArrayExists): SupportLevel = {
+ val elementType =
expr.argument.dataType.asInstanceOf[ArrayType].elementType
+ elementType match {
+ case BooleanType | ByteType | ShortType | IntegerType | LongType |
FloatType | DoubleType |
+ _: DecimalType | DateType | TimestampType | TimestampNTZType |
StringType =>
+ Compatible()
+ case _ => Unsupported(Some(s"element type not supported: $elementType"))
Review Comment:
Yes, but we can add complex type support later as a separate PR to keep this
one easier to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
