coderfender commented on PR #21456: URL: https://github.com/apache/datafusion/pull/21456#issuecomment-4230618362
Pushed a commit to move out bitmap based accumulators to a separate function with a `cold` hint to compiler. Benchmarks on my machine slow that i64 path is now slightly faster so my hunch is that this should be same as main branch : ``` group bitmap_cold_hint main ----- ---------------- ---- count_distinct i16 bitmap 1.00 2.9±0.03µs ? ?/sec 27.65 80.7±0.62µs ? ?/sec count_distinct i64 80% distinct 1.00 46.7±0.22µs ? ?/sec 1.05 48.9±1.01µs ? ?/sec count_distinct i64 99% distinct 1.00 47.3±0.77µs ? ?/sec 1.08 51.0±3.38µs ? ?/sec count_distinct i8 bitmap 1.00 1073.7±7.10ns ? ?/sec 15.83 17.0±0.16µs ? ?/sec count_distinct u16 bitmap 1.00 3.1±0.19µs ? ?/sec 26.58 81.4±0.84µs ? ?/sec count_distinct u8 bitmap 1.00 1083.1±20.24ns ? ?/sec 15.89 17.2±0.17µs ? ?/sec ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
