nuno-faria commented on code in PR #21557:
URL: https://github.com/apache/datafusion/pull/21557#discussion_r3069680964
##########
datafusion/spark/src/function/math/modulus.rs:
##########
Review Comment:
Suggestion: since the code that checks floats is similar to the one for the
integers, I wonder if it would be better to restructure like this:
```rust
if enable_ansi_mode {
Ok(rem(left, right)?)
} else {
// code from lines 58-65
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
