zhuliquan commented on PR #11575: URL: https://github.com/apache/datafusion/pull/11575#issuecomment-2245159846
> Thanks @zhuliquan -- this makes sense to me. > > I don't understand how this issue isn't caught on the CI runner though I also got confused, `#[cfg(target_os)]` not equal to `windows`? I'am not sure that ci run unittests on real windows machine according to workflow yaml. https://github.com/apache/datafusion/blob/77311a5896272c7ed252d8cd53d48ec6ea7c0ccf/.github/workflows/rust.yml#L323-L338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
