tshauck commented on PR #11584: URL: https://github.com/apache/datafusion/pull/11584#issuecomment-2245810011
Thanks to both of you for the thoughtful feedback. @berkaysynnada, I updated infinity to use unbounded in [231a717](https://github.com/apache/datafusion/pull/11584/commits/231a717cdd94ef0145038a66c18c894b754f8695). @ozankabak, for handling π, do you mean [`libm::nextafter`](https://rust-random.github.io/rand/libm/fn.nextafter.html)? There's also a [`.next_up`](https://doc.rust-lang.org/std/primitive.f64.html#method.next_up), but unfortunately, it's in nightly. Did I overlook the actual function, or if not, any opinion on bringing in `libm` as dependency vs something w/i datafusion, albeit less robust? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
