kumarUjjawal opened a new pull request, #21739:
URL: https://github.com/apache/datafusion/pull/21739
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #19685.
## Rationale for this change
Physical explain output only showed the alias for aliased aggregates. That
made it hard to understand the plan, especially when the aggregate had a
filter, explicit RESPECT NULLS, or a custom UDAF display.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
- Keep the stored display text for aliased aggregates in physical explain
output.
- Keep normal non-aliased aggregates on their physical names, so physical
explain still shows physical detail like planner-added coercions.
- Preserve aggregate display text when reverse_expr rebuilds an aggregate.
- Add regressions for:
- aliased aggregate explain with a filter
- aliased aggregate explain with explicit RESPECT NULLS
- aliased UDAF explain with custom human_display
- reversed aliased aggregate preserving display text
- Update affected explain snapshots.
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
Yes
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
Physical explain output for aliased aggregates now shows the full aggregate
expression instead of only the alias. Non-aliased aggregate explain output
keeps the previous physical detail.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
