comphead commented on code in PR #3989:
URL: https://github.com/apache/datafusion-comet/pull/3989#discussion_r3111986267
##########
spark/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/CometShuffleExchangeExec.scala:
##########
@@ -329,108 +366,78 @@ object CometShuffleExchangeExec
false
}
- // Preserve any prior-pass fallback decision (see `CometFallback`).
- if (isMarkedForFallback(s)) {
- return false
- }
-
- if (!isCometShuffleEnabledWithInfo(s)) {
- return false
- }
+ val reasons = scala.collection.mutable.ListBuffer.empty[String]
if (!isCometNativeShuffleMode(s.conf)) {
- withInfo(s, "Comet native shuffle not enabled")
- return false
- }
-
- if (!isCometPlan(s.child)) {
- // we do not need to report a fallback reason if the child plan is not a
Comet plan
- return false
+ reasons += "Comet native shuffle not enabled"
Review Comment:
should we show an example to how to enable native shuffle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
