andygrove opened a new issue, #1608:
URL: https://github.com/apache/datafusion-ballista/issues/1608

   The Python release builds in `.github/workflows/build.yml` produce two macOS 
arm64 wheels and no macOS x86_64 wheel.
   
   ## Current behavior
   
   Two jobs both target `macos-latest`, which has resolved to arm64 since 
GitHub's runner change in 2024:
   
   - `build-python-mac-win` (matrix `os: [macos-latest, windows-latest]`) — 
uploads as `dist-macos-latest`
   - `build-macos-x86_64` (job name "Mac x86_64") — uploads as 
`dist-macos-aarch64` despite the job name
   
   Both jobs build the same `*_arm64.whl` artifact. Nothing in the workflow 
currently produces a wheel with a `*_x86_64.whl` macOS tag.
   
   ## Impact
   
   Users installing `pip install ballista` on an Intel Mac fall back to the 
source distribution and have to compile the Rust extension locally (which 
requires `protoc` and a Rust toolchain). They likely cannot install a prebuilt 
wheel.
   
   ## Expected behavior
   
   The release artifact set should contain exactly one wheel per supported 
platform:
   
   - `manylinux_2_17_x86_64.manylinux2014_x86_64`
   - `manylinux_2_17_aarch64.manylinux2014_aarch64`
   - `macosx_*_arm64`
   - `macosx_*_x86_64`
   - `win_amd64`
   - plus the `tar.gz` sdist
   
   ## Suggested fix
   
   Either pin one of the macOS jobs to `macos-13` (the last x86_64 runner) so 
it actually produces the x86_64 wheel, or use cross-compilation via `--target 
x86_64-apple-darwin` from an arm64 runner. The job name `build-macos-x86_64` 
suggests x86_64 was the original intent for that job.
   
   ## References
   
   - `.github/workflows/build.yml` (`build-python-mac-win`, 
`build-macos-x86_64`)
   - GitHub runner image change: 
https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to