alamb commented on code in PR #21912:
URL: https://github.com/apache/datafusion/pull/21912#discussion_r3178175705
##########
datafusion/physical-plan/src/recursive_query.rs:
##########
@@ -318,19 +321,6 @@ impl RecursiveQueryStream {
) -> Poll<Option<Result<RecordBatch>>> {
let baseline_metrics = self.baseline_metrics.clone();
- // Rebind to the declared output schema. The recursive term is planned
Review Comment:
this is a nice cleanup
##########
datafusion/core/tests/memory_limit/mod.rs:
##########
@@ -343,7 +343,7 @@ async fn oom_recursive_cte() {
TestCase::new()
.with_query(
"WITH RECURSIVE nodes AS (
- SELECT 1 as id
+ SELECT id FROM (VALUES (1), (NULL)) AS t(id) WHERE id IS NOT NULL
Review Comment:
why is this change needed? It is not clear to me if this is needed for this
PR 🤔
THe prior query seem valid as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
