Jefffrey commented on code in PR #21994:
URL: https://github.com/apache/datafusion/pull/21994#discussion_r3185700346
##########
datafusion/proto/src/logical_plan/mod.rs:
##########
@@ -801,8 +802,24 @@ impl AsLogicalPlan for LogicalPlanNode {
LogicalPlanType::Explain(explain) => {
let input: LogicalPlan =
into_logical_plan!(explain.input, ctx, extension_codec)?;
+ let pb_format =
protobuf::ExplainFormat::try_from(explain.format)
+ .map_err(|_| {
+ internal_datafusion_err!(
Review Comment:
We probably should format the error like so:
https://github.com/apache/datafusion/blob/7d107f09ba0e980e8885b60187a9621726c941d4/datafusion/proto/src/logical_plan/mod.rs#L835-L841
- Using proto error variant, and also including the invalid format for
visibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
