yuboxx opened a new pull request, #4222: URL: https://github.com/apache/datafusion-comet/pull/4222
## What changes were proposed in this pull request? This PR adds dictionary string support to the native Spark-compatible `unhex` expression. Dictionary arrays backed by `Utf8` or `LargeUtf8` values are unpacked and then handled by the existing string implementation. It also expands coverage for `unhex`: - Rust unit coverage for dictionary arrays with valid hex, invalid hex, null keys, and null dictionary values - Spark expression coverage with dictionary enabled and disabled - Scalar literal coverage with constant folding disabled - SQL-file coverage under `parquet.enable.dictionary=false,true` Closes #477. ## How was this patch tested? - `cargo test -p datafusion-comet-spark-expr math_funcs::unhex::test` - `./mvnw -pl spark -Dsuites=org.apache.comet.CometExpressionSuite -Dtest=none -Pspark-4.0 -Pscala-2.13 test` - `git diff --check -- native/spark-expr/src/math_funcs/unhex.rs spark/src/test/resources/sql-tests/expressions/string/unhex.sql spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
