neilconway commented on PR #22029: URL: https://github.com/apache/datafusion/pull/22029#issuecomment-4382985211
My initial thought was to have an API where the closure is passed a caller-sized byte slice. That has two shortcomings: (1) caller needs to size the byte-slice in advance (2) for efficiency, we can't initialize the contents of the slice, so (a) this needs unsafe code (b) the closure must be careful to write to EXACTLY the specified number of bytes, no more and no less. That seemed like a footgun, so I started with these safer APIs instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
