parthchandra commented on code in PR #3986:
URL: https://github.com/apache/datafusion-comet/pull/3986#discussion_r3192128980
##########
spark/src/test/scala/org/apache/comet/exec/CometJoinSuite.scala:
##########
@@ -54,21 +54,119 @@ class CometJoinSuite extends CometTestBase {
.toSeq)
}
- test("SortMergeJoin with unsupported key type should fall back to Spark") {
+ test("SortMergeJoin with TimestampType key runs natively") {
withSQLConf(
SQLConf.SESSION_LOCAL_TIMEZONE.key -> "Asia/Kathmandu",
SQLConf.ADAPTIVE_AUTO_BROADCASTJOIN_THRESHOLD.key -> "-1",
- SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "-1") {
+ SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "-1",
+ SQLConf.PREFER_SORTMERGEJOIN.key -> "true") {
withTable("t1", "t2") {
sql("CREATE TABLE t1(name STRING, time TIMESTAMP) USING PARQUET")
- sql("INSERT OVERWRITE t1 VALUES('a', timestamp'2019-01-01 11:11:11')")
+ sql(
Review Comment:
What happens if table t1 is written with one session timezone and table t2
is written with another session timezone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
