kosiew commented on code in PR #22014:
URL: https://github.com/apache/datafusion/pull/22014#discussion_r3193771226
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -1296,6 +1296,9 @@ impl SessionContext {
"Empty limit value found for '{config_name}'"
));
}
+ if limit == "0" {
Review Comment:
Nice addition to cover the helper directly 👍
Since the intended user-facing flow is `SET datafusion.runtime.* = '0'`, it
could also be helpful to add a small SQL-level regression test or SLT that
exercises something like `SET datafusion.runtime.memory_limit = '0'` and
verifies `SHOW` returns the expected value.
That would help catch any future wiring regressions between the parser and
the config layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
