SubhamSinghal commented on PR #21962: URL: https://github.com/apache/datafusion/pull/21962#issuecomment-4396928119
@mbutrovich @kosiew I have resolved following comments: 1. comment around usage of grow() instead of try_grow() 2. Recomputing join_arrays memory -- added join_arrays_mem field which holds cached size 3. try_shrink vs shrink on free -- replaced try_shrink with shrink 4. peak_mem assertion strength -- replaced test assertion with peak_mem >= join_arrays_mem 5. fixed reserved_amount doc which still refer try_grow() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
