kimjune01 opened a new pull request, #1673: URL: https://github.com/apache/datafusion-ballista/pull/1673
# Which issue does this PR close? Closes #631 # Rationale for this change `write_time` in `ShuffleWriterExec` reports the total stream duration instead of actual write time. The `None` partitioning branch wraps the entire `write_stream_to_disk` call in a timer, but `write_stream_to_disk` already records `write_time` internally per batch. The outer timer double-counts every batch write and also includes time spent waiting for upstream data. # What changes are included in this PR? Removed the outer `write_time` timer in the `None` partitioning branch of `ShuffleWriterExec::execute_shuffle_write`. `write_stream_to_disk` handles its own `write_time` measurement per batch, so the outer timer was redundant. # Are there any user-facing changes? `write_time` now accurately reflects disk write duration rather than total stream processing time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
