cyberbeam524 commented on PR #21714: URL: https://github.com/apache/datafusion/pull/21714#issuecomment-4415002669
Thank you for the feedback, @tschwarzinger @paleolimbot! I've addressed all the feedback and pushed the edits with these changes: - Validated propagation: Used target-field casting to sanitize metadata. - Strict validation: reused check_metadata_with_storage_equal for all extension types. - Canonical types: Leveraged DFUuid/DFJson try_new constructors. - Performance: Moved invariant checks and string allocations out of hot loops in the plan builder. - Added negative test cases for invalid UUID casts to check if it errors out properly. - All CI checks (fmt, clippy) are passing locally Ready for final review! 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
