alamb opened a new pull request, #22094: URL: https://github.com/apache/datafusion/pull/22094
## Which issue does this PR close? - Related to https://github.com/apache/datafusion/pull/22069 ## Rationale for this change While upgrading to sqlparser, it was not clear why there were feature gates for the `sql` feature: https://github.com/apache/datafusion/pull/22069/changes#r3204705488 What is happening is that there is a mode to avoid the sqlparser dependency that was added by @timsaucer in - #17332 I think this feature makes sense but it is a little hard to understand what is going on because it is implemented with a bunch of ` #[cfg(not(feature = "sql"))] ` and there is no central place that explains what is going on ## What changes are included in this PR? 1. Consolidate the sql ast shim structures in separate module 2. Document what is going on so it is easier to understand ## Are these changes tested? Yes by CI ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
