abhinavgautam01 commented on code in PR #1685:
URL:
https://github.com/apache/datafusion-ballista/pull/1685#discussion_r3223142270
##########
ballista/executor/src/executor_server.rs:
##########
@@ -148,6 +169,8 @@ pub async fn startup<T: 'static + AsLogicalPlan, U: 'static
+ AsExecutionPlan>(
})
};
+ wait_executor_grpc_listen(&config.bind_host, config.grpc_port).await?;
Review Comment:
wait_executor_grpc_listen takes a single SocketAddr; start_executor_process
parses bind_host + executor.metadata.grpc_port once into grpc_listen_addr for
the dynamic listen path. For standalone push, ExecutorGrpcListen::Bound skips
the TCP probe entirely because the listener is already bound. startup now
passes &ShutdownNotifier and clones only the broadcast::Sender into the gRPC
task instead of Arc-wrapping the whole notifier just to satisfy 'static...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
