martin-g commented on code in PR #1688: URL: https://github.com/apache/datafusion-ballista/pull/1688#discussion_r3224470048
########## .github/workflows/tpch.yml: ########## @@ -0,0 +1,158 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: TPC-H SF10 + +permissions: + contents: read + +concurrency: + group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }} + cancel-in-progress: true + +on: + push: + paths-ignore: + - "docs/**" + - "**.md" + - ".github/ISSUE_TEMPLATE/**" + - ".github/pull_request_template.md" + pull_request: + paths-ignore: + - "docs/**" + - "**.md" + - ".github/ISSUE_TEMPLATE/**" + - ".github/pull_request_template.md" + workflow_dispatch: + +jobs: + tpch-sf10: + name: TPC-H SF10 (all queries) + runs-on: ubuntu-latest + steps: + - uses: actions/[email protected] + with: + submodules: true + fetch-depth: 1 + + - name: Install system dependencies + run: | + sudo apt-get update + sudo apt-get install -y protobuf-compiler netcat-openbsd + + - name: Setup Rust toolchain + run: | + rustup toolchain install stable + rustup default stable + + - name: Build Ballista binaries + run: | + cargo build --profile release-nonlto --locked \ + -p ballista-scheduler \ + -p ballista-executor \ + -p ballista-benchmarks + + - name: Install tpchgen-cli + run: cargo install --locked tpchgen-cli + + - name: Generate TPC-H SF10 data + run: | + mkdir -p "$RUNNER_TEMP/tpch-data" + tpchgen-cli \ + --scale-factor 10 \ + --parts 16 \ + --format=parquet \ + --output-dir "$RUNNER_TEMP/tpch-data" + + - name: Run TPC-H queries against Ballista cluster + env: + DATA_DIR: ${{ runner.temp }}/tpch-data + WORK_DIR: ${{ runner.temp }}/work + SCHEDULER_LOG: ${{ runner.temp }}/scheduler.log + EXECUTOR_LOG: ${{ runner.temp }}/executor.log + run: | + set -euo pipefail + + mkdir -p "$WORK_DIR" + + ./target/release-nonlto/ballista-scheduler \ + --bind-host 127.0.0.1 \ + > "$SCHEDULER_LOG" 2>&1 & + SCHEDULER_PID=$! + + ./target/release-nonlto/ballista-executor \ + --bind-host 127.0.0.1 \ + --scheduler-host 127.0.0.1 \ + --concurrent-tasks 4 \ + --memory-pool-size 2GB \ + --work-dir "$WORK_DIR" \ Review Comment: ```suggestion --work-dir "$WORK_DIR" \ --scheduler-connect-timeout-seconds 10 \ ``` to give the scheduler some time to start ########## .github/workflows/tpch.yml: ########## @@ -0,0 +1,158 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: TPC-H SF10 + +permissions: + contents: read + +concurrency: + group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }} + cancel-in-progress: true + +on: + push: + paths-ignore: + - "docs/**" + - "**.md" + - ".github/ISSUE_TEMPLATE/**" + - ".github/pull_request_template.md" + pull_request: + paths-ignore: + - "docs/**" + - "**.md" + - ".github/ISSUE_TEMPLATE/**" + - ".github/pull_request_template.md" + workflow_dispatch: + +jobs: + tpch-sf10: + name: TPC-H SF10 (all queries) + runs-on: ubuntu-latest + steps: + - uses: actions/[email protected] + with: + submodules: true + fetch-depth: 1 + + - name: Install system dependencies + run: | + sudo apt-get update + sudo apt-get install -y protobuf-compiler netcat-openbsd + + - name: Setup Rust toolchain + run: | + rustup toolchain install stable + rustup default stable Review Comment: ```suggestion - name: Setup Rust toolchain uses: ./.github/actions/setup-builder with: rust-version: stable ``` ########## .github/workflows/tpch.yml: ########## @@ -0,0 +1,158 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: TPC-H SF10 + +permissions: + contents: read + +concurrency: + group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }} + cancel-in-progress: true + +on: + push: + paths-ignore: + - "docs/**" + - "**.md" + - ".github/ISSUE_TEMPLATE/**" + - ".github/pull_request_template.md" + pull_request: + paths-ignore: + - "docs/**" + - "**.md" + - ".github/ISSUE_TEMPLATE/**" + - ".github/pull_request_template.md" + workflow_dispatch: + +jobs: + tpch-sf10: + name: TPC-H SF10 (all queries) + runs-on: ubuntu-latest + steps: + - uses: actions/[email protected] + with: + submodules: true + fetch-depth: 1 + + - name: Install system dependencies + run: | + sudo apt-get update + sudo apt-get install -y protobuf-compiler netcat-openbsd + + - name: Setup Rust toolchain + run: | + rustup toolchain install stable + rustup default stable + + - name: Build Ballista binaries + run: | + cargo build --profile release-nonlto --locked \ + -p ballista-scheduler \ + -p ballista-executor \ + -p ballista-benchmarks + + - name: Install tpchgen-cli + run: cargo install --locked tpchgen-cli Review Comment: Do we want to pin tpchgen-cli to a specific version ? Or always use the latest one ? ########## .github/workflows/tpch.yml: ########## @@ -0,0 +1,158 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: TPC-H SF10 + +permissions: + contents: read + +concurrency: + group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }} + cancel-in-progress: true + +on: + push: + paths-ignore: + - "docs/**" + - "**.md" + - ".github/ISSUE_TEMPLATE/**" + - ".github/pull_request_template.md" + pull_request: + paths-ignore: + - "docs/**" + - "**.md" + - ".github/ISSUE_TEMPLATE/**" + - ".github/pull_request_template.md" + workflow_dispatch: + +jobs: + tpch-sf10: + name: TPC-H SF10 (all queries) + runs-on: ubuntu-latest + steps: + - uses: actions/[email protected] + with: + submodules: true + fetch-depth: 1 + + - name: Install system dependencies + run: | + sudo apt-get update + sudo apt-get install -y protobuf-compiler netcat-openbsd + + - name: Setup Rust toolchain + run: | + rustup toolchain install stable + rustup default stable + + - name: Build Ballista binaries + run: | + cargo build --profile release-nonlto --locked \ + -p ballista-scheduler \ + -p ballista-executor \ + -p ballista-benchmarks + + - name: Install tpchgen-cli + run: cargo install --locked tpchgen-cli + + - name: Generate TPC-H SF10 data + run: | + mkdir -p "$RUNNER_TEMP/tpch-data" + tpchgen-cli \ + --scale-factor 10 \ + --parts 16 \ + --format=parquet \ + --output-dir "$RUNNER_TEMP/tpch-data" + + - name: Run TPC-H queries against Ballista cluster + env: + DATA_DIR: ${{ runner.temp }}/tpch-data + WORK_DIR: ${{ runner.temp }}/work + SCHEDULER_LOG: ${{ runner.temp }}/scheduler.log + EXECUTOR_LOG: ${{ runner.temp }}/executor.log + run: | + set -euo pipefail + + mkdir -p "$WORK_DIR" + + ./target/release-nonlto/ballista-scheduler \ + --bind-host 127.0.0.1 \ + > "$SCHEDULER_LOG" 2>&1 & + SCHEDULER_PID=$! + + ./target/release-nonlto/ballista-executor \ + --bind-host 127.0.0.1 \ Review Comment: ```suggestion --bind-host 127.0.0.1 \ --bind-port 50051 \ ``` be explicit, for https://github.com/apache/datafusion-ballista/pull/1688/changes#diff-a25cf5db45bcbe334c91053366ed8e6254b680c150870392421a692bd3eb8bc5R129 ########## .github/workflows/tpch.yml: ########## @@ -0,0 +1,158 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: TPC-H SF10 + +permissions: + contents: read + +concurrency: + group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }} + cancel-in-progress: true + +on: + push: + paths-ignore: + - "docs/**" + - "**.md" + - ".github/ISSUE_TEMPLATE/**" + - ".github/pull_request_template.md" + pull_request: + paths-ignore: + - "docs/**" + - "**.md" + - ".github/ISSUE_TEMPLATE/**" + - ".github/pull_request_template.md" + workflow_dispatch: + +jobs: + tpch-sf10: + name: TPC-H SF10 (all queries) + runs-on: ubuntu-latest + steps: + - uses: actions/[email protected] + with: + submodules: true + fetch-depth: 1 + + - name: Install system dependencies + run: | + sudo apt-get update + sudo apt-get install -y protobuf-compiler netcat-openbsd + + - name: Setup Rust toolchain + run: | + rustup toolchain install stable + rustup default stable + + - name: Build Ballista binaries + run: | + cargo build --profile release-nonlto --locked \ + -p ballista-scheduler \ + -p ballista-executor \ + -p ballista-benchmarks + + - name: Install tpchgen-cli + run: cargo install --locked tpchgen-cli Review Comment: ```suggestion uses: taiki-e/install-action@de6bbd1333b8f331563d54a051e542c7dfef81c3 # v2.68.34 with: tool: tpchgen-cli ``` taiki-e/install uses `cargo binstall` and it is much faster than building the tool for each run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
