kumarUjjawal commented on code in PR #22132:
URL: https://github.com/apache/datafusion/pull/22132#discussion_r3232005125


##########
datafusion/sqllogictest/test_files/aggregate.slt:
##########


Review Comment:
   Also could you add a non-empty positive case alongside the empty-table 
reproducer?



##########
datafusion/sqllogictest/test_files/aggregate.slt:
##########


Review Comment:
   We should also add this test `SELECT AVG(v1) FROM t1 GROUP BY false;`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to