github-actions[bot] commented on PR #22136: URL: https://github.com/apache/datafusion/pull/22136#issuecomment-4440888468
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-ffi v53.1.0 (current) Built [ 56.777s] (current) Parsing datafusion-ffi v53.1.0 (current) Parsed [ 0.055s] (current) Building datafusion-ffi v53.1.0 (baseline) Built [ 55.910s] (baseline) Parsing datafusion-ffi v53.1.0 (baseline) Parsed [ 0.054s] (baseline) Checking datafusion-ffi v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.233s] 222 checks: 220 pass, 1 fail, 1 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field FFI_ExecutionPlan.metrics in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:75 --- warning repr_c_plain_struct_fields_reordered: struct fields reordered in repr(C) struct --- Description: A public repr(C) struct had its fields reordered. This can change the struct's memory layout, possibly breaking FFI use cases that depend on field position and order. ref: https://doc.rust-lang.org/reference/type-layout.html#reprc-structs impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/repr_c_plain_struct_fields_reordered.ron Failed in: FFI_ExecutionPlan.clone moved from position 7 to 8, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:79 FFI_ExecutionPlan.release moved from position 8 to 9, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:82 FFI_ExecutionPlan.private_data moved from position 9 to 10, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:86 FFI_ExecutionPlan.library_marker_id moved from position 10 to 11, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:91 Summary semver requires new major version: 1 major and 0 minor checks failed Warning produced 1 major and 0 minor level warnings Finished [ 114.355s] datafusion-ffi Building datafusion-physical-expr-common v53.1.0 (current) Built [ 19.269s] (current) Parsing datafusion-physical-expr-common v53.1.0 (current) Parsed [ 0.019s] (current) Building datafusion-physical-expr-common v53.1.0 (baseline) Built [ 19.057s] (baseline) Parsing datafusion-physical-expr-common v53.1.0 (baseline) Parsed [ 0.019s] (baseline) Checking datafusion-physical-expr-common v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.184s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 39.321s] datafusion-physical-expr-common ``` </details> <!-- semver-check-comment --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
