mailmindlin opened a new issue, #22152:
URL: https://github.com/apache/datafusion/issues/22152

   ### Is your feature request related to a problem or challenge?
   
   `ExecutionPlan::partition_statistics()` is not currently reachable through 
datafusion-ffi: `FFI_ExecutionPlan` exposes most of the trait (`properties`, 
`children`, `with_new_children`, `name`, `execute`, `repartitioned`, and [soon 
`metrics`](https://github.com/rerun-io/reality/pull/1977)) but has no function 
pointer for `partition_statistics()`, so 
`ForeignExecutionPlan::partition_statistics()` falls through to the trait 
default implementation and always returns `Statistics::new_unknown()`.
   
   ### Describe the solution you'd like
   
   Expose `partition_statistics()` across the FFI boundary by serializing the 
Statistics struct using protobuf, similar to how filters are currently handled. 
This avoids creating a parallel type system.
   
   ### Describe alternatives you've considered
   
   Create a mapping/conversion layer from the current Statistics type to 
FFI-safe types. Rejected: it requires defining many type variants and protobuf 
serialization results in much less code.
   
   ### Additional context
   
   I have a PR already authored.
   
   This will be a breaking change requiring a major version bump.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to