kosiew opened a new pull request, #22196:
URL: https://github.com/apache/datafusion/pull/22196
## Which issue does this PR close?
* Part of #22192
## Rationale for this change
The current semver CI workflow compares pull requests against the base
branch (`main`) instead of the latest released API surface. This can produce
false-positive semver failures for APIs that were introduced after the last
release and later changed before release.
This change aligns semver validation with the latest stable release tag so
that checks reflect compatibility guarantees for released APIs rather than
unreleased development state.
## What changes are included in this PR?
* Added a `latest-release-tag` command to `ci/scripts/changed_crates.sh`
that:
* selects the latest stable semver tag
* ignores release candidates and malformed tags
* Updated semver CI to:
* fetch git tags during checkout
* determine the latest release tag dynamically
* run `cargo semver-checks` against that release tag instead of
`apache/${BASE_REF}`
* Updated the PR comment workflow to:
* persist and validate the selected release tag
* mention the release tag used for comparison in failure comments
* Added `ci/scripts/test_changed_crates.sh` covering:
* ignoring RC and malformed tags
* failure when no valid release tags exist
* current behavior for prefixed tags such as `v54.0.0`
## Are these changes tested?
Yes.
Added `ci/scripts/test_changed_crates.sh` with coverage for:
* selecting the latest stable release tag
* ignoring RC and malformed tags
* handling repositories without valid release tags
* ignoring prefixed version tags for now
The workflow also runs these tests during CI.
## Are there any user-facing changes?
No user-facing changes. This only updates CI semver-check behavior and PR
comment messaging.
## LLM-generated code disclosure
This PR includes LLM-generated code and comments. All LLM-generated content
has been manually reviewed and tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
