nathanb9 commented on code in PR #22322: URL: https://github.com/apache/datafusion/pull/22322#discussion_r3276136486
########## datafusion/physical-plan/src/aggregates/group_values/mod.rs: ########## @@ -30,7 +30,7 @@ use datafusion_expr::EmitTo; pub mod multi_group_by; -mod row; +pub mod row; Review Comment: Required for the benchmark to directly instantiate GroupValuesRows with the same Int32 schema used by GroupValuesColumn. Without this, benchmarks can only trigger the row-based path via an unsupported type, which makes the comparison unfair. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
