andygrove commented on issue #4389: URL: https://github.com/apache/datafusion-comet/issues/4389#issuecomment-4514107904
> > Merge queue looks promising +1 > > with MQ there are some drawbacks, so effectively you running CI twice and if CI fails during MQ cycle your PR is removed from the queue. > > I'm still playing with [#4292](https://github.com/apache/datafusion-comet/pull/4292) to offboard heavyweight tasks, but need some time, straightfwd CI port from Spark to Comet doesn't properly work There are some nice advantages to #4292 approach: - contributors do not have to wait for maintainers to approve workflows - contributors get their own resource allocation so do have to wait with tasks queued due to shared ASF resources - we can probably use larger runners since it runs in contributor account - also we could parameterize it so users can choose runners (paid or free) by overrideing variable: ```yaml jobs: build: runs-on: ${{ vars.RUNNER || 'ubuntu-latest' }} ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
