mbutrovich commented on code in PR #4309:
URL: https://github.com/apache/datafusion-comet/pull/4309#discussion_r3291340893
##########
native/core/src/parquet/objectstore/s3.rs:
##########
@@ -78,11 +79,35 @@ pub fn create_store(
source: "Missing bucket name in S3 URL".into(),
})?;
- let credential_provider =
- get_runtime().block_on(build_credential_provider(configs, bucket,
min_ttl))?;
- builder = match credential_provider {
- Some(provider) => builder.with_credentials(Arc::new(provider)),
- None => builder.with_skip_signature(true),
+ // Parquet path: catalog_properties is empty; vendors here read from
Hadoop conf.
+ let empty_props: HashMap<String, String> = HashMap::new();
+ let bridge = match lookup_provider_class(configs, bucket) {
+ Some(provider_class) => match CometS3CredentialBridge::new(
+ provider_class,
+ bucket,
+ bucket,
+ url.path(),
+ AccessMode::Read,
+ &empty_props,
+ ) {
+ Ok(b) => Some(b),
+ Err(e) => {
+ log::warn!(
Review Comment:
Good call. The user explicitly named a provider, so silently falling back
hides a real misconfiguration and can resolve to the wrong identity. Changed to
propagate the error out of `create_store`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
