alamb commented on code in PR #11740:
URL: https://github.com/apache/datafusion/pull/11740#discussion_r1698598079
##########
datafusion/expr/src/udaf.rs:
##########
@@ -351,12 +351,8 @@ pub trait AggregateUDFImpl: Debug + Send + Sync {
/// Return the fields used to store the intermediate state of this
accumulator.
///
- /// # Arguments:
- /// 1. `name`: the name of the expression (e.g. AVG, SUM, etc)
- /// 2. `value_type`: Aggregate function output returned by
[`Self::return_type`] if defined, otherwise
- /// it is equivalent to the data type of the first arguments
- /// 3. `ordering_fields`: the fields used to order the input arguments, if
any.
- /// Empty if no ordering expression is provided.
+ /// args: [`StateFieldsArgs`] contains information about the fields that
an
+ /// aggregate function's accumulator should have.
Review Comment:
```suggestion
/// args: [`StateFieldsArgs`] arguments passed to the
/// aggregate function's accumulator.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
