albertlockett commented on PR #22647: URL: https://github.com/apache/datafusion/pull/22647#issuecomment-4607985320
> The SLTs should at least check the dictionary type is preserved (e.g. check via `arrow_typeof()`), otherwise its unclear this PR is achieving the desired effect Maybe I should just create a new issue instead of linking to https://github.com/apache/datafusion/issues/20935. My intention here wasn't actually to preserve dictionary encoding necessarily. This issue just seemed like the most relevant one that was already open. My real intention here was just to stop these functions returning an error when invoked with a Dictionary arg. Would you find that acceptable @Jefffrey? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
