jayzhan211 commented on code in PR #11724:
URL: https://github.com/apache/datafusion/pull/11724#discussion_r1701892563
##########
datafusion/common/src/column.rs:
##########
@@ -372,7 +372,7 @@ impl FromStr for Column {
impl fmt::Display for Column {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
- write!(f, "{}", self.flat_name())
+ write!(f, "{}", self.quoted_flat_name())
Review Comment:
I thought identifier are the one double quoted in your ticket 😕, but it
seems you are modifying column
##########
datafusion/common/src/column.rs:
##########
@@ -372,7 +372,7 @@ impl FromStr for Column {
impl fmt::Display for Column {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
- write!(f, "{}", self.flat_name())
+ write!(f, "{}", self.quoted_flat_name())
Review Comment:
I thought identifier are the one to be double quoted in your ticket 😕, but
it seems you are modifying column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
