davidlghellin commented on code in PR #22248:
URL: https://github.com/apache/datafusion/pull/22248#discussion_r3369847353
##########
datafusion/functions/src/math/ceil.rs:
##########
@@ -191,11 +191,238 @@ impl ScalarUDFImpl for CeilFunc {
}
fn evaluate_bounds(&self, inputs: &[&Interval]) -> Result<Interval> {
- let data_type = inputs[0].data_type();
- Interval::make_unbounded(&data_type)
+ let [input] = inputs else {
+ return exec_err!(
+ "ceil expected 1 argument for bounds evaluation, got {}",
+ inputs.len()
+ );
+ };
+ let data_type = input.data_type();
+ match (ceil_scalar(input.lower()), ceil_scalar(input.upper())) {
+ (Some(lo), Some(hi)) => Interval::try_new(lo, hi)
+ .or_else(|_| Interval::make_unbounded(&data_type)),
+ _ => Interval::make_unbounded(&data_type),
+ }
+ }
+
+ fn propagate_constraints(
+ &self,
+ interval: &Interval,
+ inputs: &[&Interval],
+ ) -> Result<Option<Vec<Interval>>> {
+ let [input_interval] = inputs else {
+ return exec_err!(
+ "ceil expected 1 argument for constraint propagation, got {}",
+ inputs.len()
+ );
+ };
+ // ceil(x) ∈ [N, M] → x ∈ (ceil(N)−1, floor(M)]
+ // Normalize bounds to integers ceil can actually take before mapping
back.
+ let lo = match interval.lower() {
+ ScalarValue::Float64(Some(n)) if n.is_finite() => {
+ Some(ScalarValue::Float64(Some(n.ceil() - 1.0)))
+ }
+ ScalarValue::Float32(Some(n)) if n.is_finite() => {
+ Some(ScalarValue::Float32(Some(n.ceil() - 1.0)))
+ }
+ _ => None,
+ };
+ let hi = match interval.upper() {
+ ScalarValue::Float64(Some(n)) if n.is_finite() => {
+ Some(ScalarValue::Float64(Some(n.floor())))
+ }
+ ScalarValue::Float32(Some(n)) if n.is_finite() => {
+ Some(ScalarValue::Float32(Some(n.floor())))
+ }
+ _ => None,
+ };
+ match (lo, hi) {
+ (Some(lo), Some(hi)) => {
+ let constraint = Interval::try_new(lo, hi)?;
+ Ok(input_interval.intersect(constraint)?.map(|r| vec![r]))
+ }
+ _ => Ok(Some(vec![(*input_interval).clone()])),
Review Comment:
Done — one-sided bounds now narrow correctly via `lo.unwrap_or_else(||
input.lower().clone())` (and analog for `hi`) + intersect. Added regression
tests for both directions. Resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
