2010YOUY01 opened a new issue, #22989: URL: https://github.com/apache/datafusion/issues/22989
### Is your feature request related to a problem or challenge? #22921 has refactored `approx_distinct` into a more generic implementation over different input types, now it's easy to support additional arg types. (Thanks to @Jefffrey for pointing it out in the review) ### Describe the solution you'd like 1. Identify the unsupported types 2. Plan them into the generic implementation of `Accumulator` and `GroupsAccumulator` (see #22921 for details) 3. Add `sqllogictest`s Note we don't have to support all applicable types at once, some complex type might get tricky to test, so I prefer to do this incrementally ### Describe alternatives you've considered _No response_ ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
