kosiew commented on code in PR #22999:
URL: https://github.com/apache/datafusion/pull/22999#discussion_r3441323238


##########
datafusion/sql/src/unparser/dialect.rs:
##########
@@ -333,6 +338,15 @@ pub enum CharacterLengthStyle {
     CharacterLength,
 }
 
+/// `DistinctFromStyle` to use for unparsing `IsDistinctFrom` and 
`IsNotDistinctFrom` operators
+#[derive(Clone, Copy, PartialEq)]
+pub enum DistinctFromStyle {
+    /// DBMS supports `IS (NOT) DISTINCT FROM`
+    FullText,
+    /// DMBS supports equivalent operations via `<=>` and `NOT <=>`

Review Comment:
   Nice improvement to the docs.
   
   Small nit: `DMBS` looks like a typo and should probably be `DBMS`.
   
   Optional cleanup only, no behavioral impact.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to