kosiew commented on code in PR #1605:
URL:
https://github.com/apache/datafusion-python/pull/1605#discussion_r3450601068
##########
python/tests/test_functions.py:
##########
Review Comment:
Changed:
- python/datafusion/functions/__init__.py
- collapsed warning helpers into single
_warn_if_expr_for_literal_arg
- updated temporal _date_part / _date_trunc callers
- python/tests/test_functions.py
- digest behavior test now uses native method strings
- encode / decode behavior test now uses native "base64"
Changed docs/source/user-guide/common-operations/functions.md:
- arrow_cast(..., string_literal("Float64")) → arrow_cast(...,
"Float64")
- arrow_cast(..., str_lit("Int32")) → arrow_cast(..., "Int32")
- removed unused string_literal, str_lit imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
