alamb commented on code in PR #22943: URL: https://github.com/apache/datafusion/pull/22943#discussion_r3453218001
########## datafusion/sql/src/expr/mod.rs: ########## @@ -54,6 +54,13 @@ mod substring; mod unary_op; mod value; +/// Multiplier applied to `datafusion.sql_parser.recursion_limit` to bound the +/// depth of a binary-operator expression tree. A flat operator chain such as +/// `a OR b OR c OR ...` only consumes a single level of parser recursion yet Review Comment: is there a reason that a `a OR b OR c OR ..` only consumes a single parser recursion level? Would it be possible to just update the code so that `a OR b OR c ...` updates the recursion protection correctly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
