zhuqi-lucas commented on PR #23128: URL: https://github.com/apache/datafusion/pull/23128#issuecomment-4785490326
Addressed all four Copilot comments in 29114c31c: | Comment | Fix | | --- | --- | | `mod.rs:945` — allow-list missing negative-size check | `group_column_supported_type` now rejects `FixedSizeList(_, n)` with `n < 0` before falling through to the inner-type matcher. | | `mod.rs:1103` — dispatcher missing negative-size check | `make_group_column` returns `not_impl_err!` for `FixedSizeList(_, n < 0)` (defense in depth so direct callers also fail safely). | | `fixed_size_list.rs:75` — `as usize` can wrap | Constructor now `assert!(list_len >= 0)` with a clear message; `list_len_usize` switched to `usize::try_from(...).expect(...)` so a future invariant break surfaces as a panic, not a silent wrap. | | `fixed_size_list.rs:103` — `value(rhs_row)` per compare | `equal_to` now borrows `list_array.values()` + `value_offset(rhs_row)` like `append_val` does; zero allocations per equality check on the grouping hot path. | New test `negative_list_size_is_rejected_by_allow_list_and_dispatcher` locks in the guard at both surfaces. 13/13 FSL tests pass, 128/128 aggregates pass, clippy clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
