alamb commented on PR #23182: URL: https://github.com/apache/datafusion/pull/23182#issuecomment-4811982714
> I reran the benchmarks on my machine with SF1, and it looks like there's essentially no difference. It seems TPC-DS SF1 just isn't suitable for evaluating this kind of optimization. In hindsight, it also wouldn't have been able to reveal the impact of your previous changes. TPCH queries don't have many high cardinality groupings so I am not surprosed they don't show much of a difference (there is one with a subquery I think) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
